Memory game

Hi, 

Thanks for the response, but that isn't the problem.

Both versions of the code get 83/100. And the test which fails is the 5th one, not the 6th.

Hmm,

Then what's probably not working is the removal of matching elements, either remove both elements at once as with JS splice or remove by given element and not the index, since when removing with the first index the position of the second index gets modified and the wrong element can get removed.

C# example:

                        Console.WriteLine($"Congrats! You have found matching elements - {list[startIndex]}!");
                        string target1 = list[startIndex];
                        string target2 = list[endIndex];

                        int targetIndex1 = list.FindIndex(x => x == target1);
                        list.RemoveAt(targetIndex1);

                        int targetIndex2 = list.FindIndex(x => x == target2);
                        list.RemoveAt(targetIndex2);

Actually, the problem was I didn't check whether the List was empty before the while loop reads a new input.I did check it but in the beginning of the loop: 

while (!input.equals("end")) {
            if (inputList.size() == 0) {
                isWinner = true;
                break;
            }
            countMoves += 1;
            String[] tokens = input.split(" ");
            int index1 = Integer.parseInt(tokens[0]);
            int index2 = Integer.parseInt(tokens[1]);
            if (areIndexesValid(index1, index2, inputList)) {
                if (inputList.get(index1).equals(inputList.get(index2))) {
                    System.out.printf("Congrats! You have found matching elements - %s!%n", inputList.get(index1));
                    if (index1 < index2) {
                        inputList.remove(index2);
                        inputList.remove(index1);
                    } else {
                        inputList.remove(index1);
                        inputList.remove(index2);
                    }
                } else {
                    System.out.println("Try again!");
                }
            } else {
                String penaltyElement = String.format("-%da", countMoves);
                int midElement = inputList.size() / 2;
                inputList.add(midElement, penaltyElement);
                inputList.add(midElement, penaltyElement);
                System.out.println("Invalid input! Adding additional elements to the board");
            }
            input = scan.nextLine();
        } 

Therefore, the failed test didn't break from the loop when the list was empty and was trying to read new input from the console. That was the problem. Here is the correct code:

while (!input.equals("end")) {
    countMoves += 1;
    String[] tokens = input.split(" ");
    int index1 = Integer.parseInt(tokens[0]);
    int index2 = Integer.parseInt(tokens[1]);
    if (areIndexesValid(index1, index2, inputList)) {
        if (inputList.get(index1).equals(inputList.get(index2))) {
            System.out.printf("Congrats! You have found matching elements - %s!%n", inputList.get(index1));
            if (index1 < index2) {
                inputList.remove(index2);
                inputList.remove(index1);
            } else {
                inputList.remove(index1);
                inputList.remove(index2);
            }
            if (inputList.size() == 0) {
                isWinner = true;
                break;
            }
        } else {
            System.out.println("Try again!");
        }
    } else {
        String penaltyElement = String.format("-%da", countMoves);
        int midIndex = inputList.size() / 2;
        inputList.add(midIndex, penaltyElement);
        inputList.add(midIndex, penaltyElement);
        System.out.println("Invalid input! Adding additional elements to the board");
    }
    input = scan.nextLine();
}